Fix: Creating ZIP archives with no file extension (Cherry-pick of #21694) #21706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #21693 There are a number of changes involved: * Add a `--adjust-sfx` command-line flag when invoking the `zip` binary -- the actual fix for the bug * Modify the `test_create_zip_archive` unit test: * Parametrize it for multiple test scenarios * Modify the last section, as it was failing for anything but `.zip` extensions * **Note**: This is a best-effort change that I'm not super confident in. There may be better or more canonical ways to do this * Remove the unsed `ZipBinary.create_archive_argv` method
|
I've marked this as draft for now, because I want to get #21770 out, without any changes that aren't included in rc0. |
huonw
approved these changes
Jan 16, 2025
|
Oops, forgot about this after I released 2.23.1 😅 |
huonw
added
the
release-notes:not-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21693
There are a number of changes involved:
--adjust-sfxcommand-line flag when invoking thezipbinary -- the actual fix for the bugtest_create_zip_archiveunit test:.zipextensionsZipBinary.create_archive_argvmethod